update empower-core and babel-plugin-espower to make t._capt and t._expr unnecessary
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…._expr` unnecessary - babel-plugin-espower 2.1.0 embeds value capturing helper (`_capt` and `_expr`) into transpiled code. Therefore, copying `t._capt` and `t._expr` is not required any more - In addition, babel-plugin-espower 2.1.0 is refactored a lot to reduce dependencies - empower-core 0.4.0 stop adding `_capt` and `_expr` methods into assertion object refs: #302 (comment) refs: power-assert-js/babel-plugin-espower#11 refs: twada/empower-core#3
Member
|
Yay! LGTM :) |
Contributor
|
Awesome! |
jamestalmage
added a commit
that referenced
this pull request
Jan 10, 2016
update empower-core and babel-plugin-espower to make `t._capt` and `t._expr` unnecessary
Contributor
Author
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates empower-core to 0.4.0 and babel-plugin-espower to 2.1.0 to make
t._captandt._exprunnecessary.babel-plugin-espower 2.1.0 embeds value capturing helper (
_captand_expr) into transpiled code. Therefore, copyingt._captandt._expris not required any more. In addition, babel-plugin-espower 2.1.0 is refactored a lot to reduce dependencies. This will speed-up installation time a little.empower-core 0.4.0 stop adding
_captand_exprmethods into assertion object.refs:
tparameter_captand_exprfrom empower-core